DONT MERGE Renaming removed file event for consistency #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathan-perucca Agree with your comment. But I think this will break the flow of existing user base who are using the component, as they will be listening to @rowanwins what do you think? |
|
Good pickup @jonathan-perucca but as @vrajroham suggests this would be a breaking change and so would require a major release. I'm going to tag as |
rowanwins
changed the title
rowanwins
reviewed
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that for removing file event, the event naming consistency wasn't followed :
vdropzone-file-addedorvdropzone-files-addedfor exampleversus
vdropzone-removed-file