-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES5 Compatiblitiy #480
base: master
Are you sure you want to change the base?
ES5 Compatiblitiy #480
Conversation
This seems like a really good and simple fix @oh-yeah - I'll try and take a look over the next few nights and get it merged in and released. |
Hi @rowanwins! First of all thank you so much for having created this component, it is very useful for a project I am working on at the moment! Also wanted to say that I am very much looking forward to seeing this PR released, as we need to have our project compatible with Internet Explorer. Thanks again for your efforts! |
@rowanwins Any luck implementing this fix? |
+1 |
Hi you can fork @oh-yeah work and build and replace in your package.json "vue2-dropzone": "git+https://github.com/yourRepo/vue-dropzone.git", Actually i use this tips. |
Actually this PR is broken. I just ran some tests. |
Changing data() { ... } to data: function() { ... } breaks scoping and shouldn't be required in the first place. |
It's not appropriate to force this package back to ancient Javascript standards just because you have to support an ancient, garbage browser. Use Babel to transpile the code to ES5 or whatever you need. Make sure it's not in your exclusion list if you use Webpack (node_modules usually is). Worst-case, the package should be modified to use Babel in its build step to generate ES5 dist files. The source code should not be modified. |
I agree with @hackel. project requirements might change so instead of shipping code for IE11 , we can simply expose src directory and allow user build config to take over. only drawback is for users , who is using vue-dropzone from cdn(direct script tag).I think most of the projects which needs ie supports uses some sort of build setup or cli.In any case, I think we should expose src dir in pkg.json file. I have created pull request:- please review. For people who want IE11 ASAP. look into patch-package(https://www.npmjs.com/package/patch-package) |
ES5 Compatibility changes for IE, fixes #439. I just converted arrow functions to regular functions and other small changes to get the library running on IE.
I currently use Azure, so I'm unable to test any AWS specific code.