Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugins composer.json format #9405

Merged
merged 23 commits into from
Apr 5, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Apr 4, 2024

needed for #9241

also simplify phpunit configs

@mvorisek mvorisek changed the title Fix plugins composer json Fix plugins composer.json format Apr 4, 2024
@mvorisek mvorisek force-pushed the fix_plugins_composer_json branch from 5485b7a to 3df614f Compare April 4, 2024 10:49
@mvorisek mvorisek marked this pull request as ready for review April 4, 2024 11:04
@mvorisek mvorisek marked this pull request as draft April 4, 2024 11:27
@mvorisek mvorisek force-pushed the fix_plugins_composer_json branch 2 times, most recently from 4c613bc to 40dd380 Compare April 5, 2024 09:36
@mvorisek mvorisek force-pushed the fix_plugins_composer_json branch from 0af83f7 to 06daf0f Compare April 5, 2024 09:57
@mvorisek mvorisek marked this pull request as ready for review April 5, 2024 09:58
@mvorisek
Copy link
Contributor Author

mvorisek commented Apr 5, 2024

@alecpl may I ask you to merge this PR so I can continue with #9241?

@alecpl alecpl merged commit 7367953 into roundcube:master Apr 5, 2024
16 checks passed
@alecpl
Copy link
Member

alecpl commented Apr 5, 2024

Independently from this PR I'm wondering why number of unit tests is different on e.g. PHP 7.3 and PHP 8.3.

@mvorisek
Copy link
Contributor Author

mvorisek commented Apr 5, 2024

@alecpl run phpunit with --list-tests

@mvorisek mvorisek deleted the fix_plugins_composer_json branch April 5, 2024 16:24
Copy link

@tomasreyes tomasreyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exfellent

@tomasreyes
Copy link

needed for #9241

also simplify phpunit configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants