Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(devops): 💄 add fontawesome Quarto extension, since the theme uses it #41

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

lwjohnst86
Copy link
Member

Description

We use fontawesome icons in the website, so needed to add the extension to actually render them.

Reviewer Focus

This PR needs a quick review.

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner September 26, 2024 11:44
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that most of these are either autogenerated or copied from other course repos?

@lwjohnst86
Copy link
Member Author

These? The files? They are created by following the instructions on the r3-theme repo ☺️ using Quarto CLI to add extensions.

@lwjohnst86 lwjohnst86 merged commit 41d00a0 into main Sep 26, 2024
1 check failed
@lwjohnst86 lwjohnst86 deleted the style/add-fontawesome-extension branch September 26, 2024 12:02
@signekb
Copy link
Member

signekb commented Sep 26, 2024

Yessss, they = the files. Sorry, for not being clear on that 😁
But thanks, the link is useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants