Add support for Python3 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b64* plays with binary in Python3
ross
reviewed
Feb 8, 2020
performant_pagination/pagination.py
Outdated
| value = b64encode(value) | ||
|
|
||
| if not isinstance(value, text_type): | ||
| value = b64encode(value).decode("utf-8") |
There was a problem hiding this comment.
Seems like this will double encode things, since value was encoded above and would go through again here.
ross
reviewed
Feb 10, 2020
|
|
||
| if not isinstance(value, text_type): | ||
| value = value.decode("utf-8") | ||
| return value |
There was a problem hiding this comment.
To double check here. Is there a case when it's not of text_type? I believe it always should be, since it comes from .value_to_string. If so I think it's sufficent do just do:
value = b64encode(value.encode('utf-8'))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b64* plays with binary in Python3