Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted possible fix on #148 and #157 #174

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

ole1986
Copy link
Collaborator

@ole1986 ole1986 commented Apr 20, 2023

We need a different approach and have a closer look into the addTextWithDirectives method unfortunately

@ole1986 ole1986 merged commit fce993f into master Apr 20, 2023
@ole1986 ole1986 deleted the hotfix/reverted-possibe-fix branch April 20, 2023 20:52
@filmo
Copy link

filmo commented Apr 24, 2023

Hi, just wanted to comment that this hot fix seems to have fixed the issue we were having with the 'header' row of a table not spanning multiple 'lines'. Prior to this hot fix it was incorrectly looking like:

wrong

It should have looked like this: (Specifically 'Billable Length' and 'Audio Classification' should not be truncated)

right

Just wanted to add this comment as I'm not sure #148 and #157 are related to this issue but something changed recently that was causing the truncation and the fix for those two issues seems to have resolved this one as well.

This is the code we use to build the header row of the table in question. We are using<b></b> for BOLD. Perhaps we should update it to <strong></strong>. (This is legacy code that has worked for years so just now reviewing.)

$y = $pdf->ezTable($transcript_table,
	array(	'doc_name'=>'<b>Transcript ID</b>','subjects'=>'<b>Speakers</b>',
			'reel_strip'=>'<b>File ID / Reel ID</b>',
			'billable'=>'<b>Billable Length</b>','style'=>'<b>Audio Classification</b>',
			'service'=>'<b>Service</b>','TC'=>'<b>TC</b>','price'=>'<b>Price</b>'),
	false,
	array(	'fontSize'=>8,'rowGap'=>4,'colGap'=>4,'width'=>534,'innerLineThickness'=>0.5,
			'outerLineThickness'  =>0.5,'xPos'=>'right','xOrientation'=>'left',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants