-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6 Count pure markup files as documentation #170
base: main
Are you sure you want to change the base?
Conversation
tests/test_analysis.py
Outdated
] | ||
actual_line_parts = AnalysisTest._line_parts("markdown", source_lines) | ||
expected_line_parts = [{"d"}, {"d"}, {"d"}, {"d"}, {"d"}, {"d"}, set()] | ||
assert actual_line_parts == expected_line_parts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The can probably be expressed more concise with:
assert all(line_part = "d" for line_part in actual_line_parts), f"line_part={line_part}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it acceptable that not all lines are categorized as documentation?
Markdown details:
{"documentationCount": 53, "documentationPercentage": 49.074074074074076, "codeCount": 0, "codePercentage": 0.0, "emptyCount": 21, "emptyPercentage": 19.444444444444443, "fileCount": 3, "filePercentage": 7.894736842105263, "isPseudoLanguage": false, "language": "Markdown", "sourceCount": 34, "sourcePercentage": 31.48148148148148, "stringCount": 34, "stringPercentage": 31.48148148148148 }
Close #6