DSL update: type coercions (finos#2533)

* Set DSL version * Set bundle version * Formatted * Cleaned * Cleaned * Added release notes * Fixed release notes * Workaround for equality check * Cleaned * Updated release notes * Update RELEASE.md --------- Co-authored-by: Hugo Hills <[email protected]>
rosetta-models · Nov 24, 2023 · 2c936c4 · 2c936c4
1 parent 1b732bd
commit 2c936c4
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 3 deletions.
diff --git a/RELEASE.md b/RELEASE.md
@@ -46,3 +46,20 @@ This release updates the FpML schema used for FpML to CDM ingestion. The version
 _Review Directions_
 
 This change has no impact on the model or test expectations. The changes can be reviewed in PR [2542](https://github.com/finos/common-domain-model/pull/2542).
+
+# *Infrastructure - Dependency Update*
+
+_What is being released?_
+
+This release updates the `rosetta-dsl` dependency.
+
+Version updates include:
+- `rosetta-dsl` 9.1.0: this release fixes several code generation issues such as [when assigning a Rosetta int to a Rosetta number](https://github.com/REGnosys/rosetta-dsl/issues/579). For further details see DSL release notes: https://github.com/REGnosys/rosetta-dsl/releases/tag/9.1.0.
+
+The issue brought to light a bug in the model having to do with the `CashPriceQuantityNoOfUnitsTriangulation` function, which has been resolved.
+
+_Review directions_
+
+Test expectations remain the same.
+
+The changes can be reviewed in PR [#2533](https://github.com/finos/common-domain-model/pull/2533).
diff --git a/pom.xml b/pom.xml
@@ -82,9 +82,9 @@
 
         <repoServerHost>oss.sonatype.org</repoServerHost>
 
-        <rosetta.bundle.version>9.1.0</rosetta.bundle.version>
+        <rosetta.bundle.version>9.2.0</rosetta.bundle.version>
         <rosetta.code-gen.version>${rosetta.bundle.version}</rosetta.code-gen.version>
-        <rosetta.dsl.version>9.0.3</rosetta.dsl.version>
+        <rosetta.dsl.version>9.1.0</rosetta.dsl.version>
 
         <xtext.version>2.27.0</xtext.version>
         <opengamma.strata.version>1.7.0</opengamma.strata.version>

diff --git a/rosetta-source/src/main/rosetta/observable-common-func.rosetta b/rosetta-source/src/main/rosetta/observable-common-func.rosetta
@@ -33,8 +33,13 @@ func CashPriceQuantityNoOfUnitsTriangulation: <"Data rule to check the relations
             extract value
             then only-element
 
-    alias cashPrice: price -> value only-element
+    alias cashPrice:
+        price
+            filter priceType = PriceTypeEnum -> AssetPrice
+            then extract value
+            then only-element
 
     set success:
         if cashPrice exists and noOfUnits exists and notional exists
         then cashPrice * noOfUnits = notional
+        else True