-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change rmw_implementation deps to be buildtool and not exec #99
base: rolling
Are you sure you want to change the base?
Conversation
Can you reorder these two new lines to follow the schema order ? |
How do you mean? I think they are in that order? Do you mean move them above the lines around them? This package already has a mixture of depend and other tags, so I didn't try to reorder everything. |
@wjwwood What is the status on this? |
Sorry, this fell through the cracks. When you poked me originally, I hesitated to merge it now because I was worried it shouldn't go into foxy. But I can merge it and then decide if we should back port it. Any thoughts on if it should be back ported? |
From a Debian point of view this is a no-op and (to my knowledge) we nowhere use these dependency types differently anywhere else. Therefore I don't mind if it does get backported or not. |
Signed-off-by: William Woodall <[email protected]>
@ahcorde can you re-review this? |
Discovered this while going over dependencies again with @chapulina. I think it should be build tool and not exec.