-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a test case for cft options not supported #217
base: rolling
Are you sure you want to change the base?
add a test case for cft options not supported #217
Conversation
Signed-off-by: Chen Lihui <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having failure case makes sense, to check rmw can create subscription even with cft failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, other than a suggestion.
Signed-off-by: Chen Lihui <[email protected]>
…d-handle-even-if-cft-failed
CI for #217, ros2/rmw_fastrtps#672, ros2/rmw_connextdds#106 12:59:52 <== '. ../venv/bin/activate && /home/jenkins-agent/workspace/ci_linux/venv/bin/colcon mixin update default' exited with return code '1'
12:59:53 Build step 'Execute shell' marked build as failure
12:59:53 $ ssh-agent -k
12:59:53 unset SSH_AUTH_SOCK;
12:59:53 unset SSH_AGENT_PID;
12:59:53 echo Agent pid 2418626 killed;
12:59:53 [ssh-agent] Stopped.
12:59:53 [CMakeGNU C Compiler (gcc)Clang (LLVM based)Clang-Tidy] Skipping execution of recorder since overall result is 'FAILURE'
12:59:53 [Cobertura] Publishing Cobertura coverage report... (It seems there is an issue in CI.) |
repos CI: |
To cooperate with updating the ros2/rmw_fastrtps#672 and ros2/rmw_connextdds#106, I need to add a test here.