Added remapping resolution for action names #1170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justus Braun <[email protected]>
Signed-off-by: Justus Braun <[email protected]>
Signed-off-by: Justus Braun <[email protected]>
Signed-off-by: Justus Braun <[email protected]>
|
I wasn't able to reproduce the test error locally. I think this might be related to/the same as #1016. |
fujitatomoya
requested changes
Jul 22, 2024
There was a problem hiding this comment.
test would be ideal, similar with https://github.com/ros2/rcl/blob/rolling/rcl/test/rcl/test_remap_integration.cpp.
most of the comments for the action client can be applied to server implementation as well.
Signed-off-by: Justus Braun <[email protected]>
Signed-off-by: Justus Braun <[email protected]>
|
I have added tests for action name remapping as requested. @fujitatomoya do you think it is necessary to add tests for local arguments passed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently remapping of action names is not possible see ros2/ros2#1312 .
I have now stumbled over this multiple times and I think it is a useful feature, so i took a shot at implementing the remapping of action names. Please let me know if you have any comments or if I overlooked something.
Fixes ros2/ros2#1312.