Update vtk_viewer CMake #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpowelson
force-pushed
the
feature/cmake_updates
branch
from
b3b0b9b to
b342ee4
Compare
jrgnicho
reviewed
Jul 7, 2020
| { | ||
| LOG4CXX_INFO(SEGMENTATION_LOGGER, "Segment " << i << " size: " << included_indices_.at(i)->GetNumberOfIds()); | ||
| CONSOLE_BRIDGE_logInform(("Segment " + std::to_string(i) + " size: " + std::to_string(included_indices_.at(i)->GetNumberOfIds())).c_str()); |
There was a problem hiding this comment.
Why console bridge over log4cxx?
There was a problem hiding this comment.
We were getting log4cxx from rosconsole. Switching to console_bridge seemed like the thing to do to make this ROS agnostic.
There was a problem hiding this comment.
Also I believe when using the ROS agnostic package within the ros ecosystem you can pipe console bridge output to ros log files.
mpowelson
force-pushed
the
feature/cmake_updates
branch
from
3e2ec55 to
19694b7
Compare
mpowelson
force-pushed
the
feature/cmake_updates
branch
2 times, most recently
from
1bce43c to
afca4a3
Compare
mpowelson
force-pushed
the
feature/cmake_updates
branch
from
afca4a3 to
39913fa
Compare
|
@Levi-Armstrong I restarted CI a few hours ago, and it still passes. |
|
Looks good to me. @jrgnicho You good with the changes? |
|
ping |
jrgnicho
approved these changes
Jul 22, 2020
DavidSpielman
pushed a commit
to DavidSpielman/noether
that referenced
this pull request
Sep 8, 2023
* Update vtk_viewer using cmake_common_scripts * Replace log4cxx with console_bridge * Address review comments and update to latest cmake_common_scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start to addressing #71. It makes vtk_viewer ROS agnostic and updates it to use the cmake_common_scripts macros. These add clang-tidy, include what you use, and cppCheck.