Plane slice planner #168
Merged
Plane slice planner #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marip8
force-pushed
the
refactor/plane-slice-planner
branch
from
89353b6 to
63922bd
Compare
|
The output from
|
|
@DavidMerzJr this will probably invalidate #123, but I think you were planning on porting those changes to |
marip8
force-pushed
the
refactor/plane-slice-planner
branch
from
63922bd to
8a281f7
Compare
DavidMerzJr
reviewed
Jun 22, 2022
noether_tpp/include/noether_tpp/tool_path_planners/raster/direction_generators.h
Outdated
Show resolved
Hide resolved
DavidMerzJr
approved these changes
Jun 22, 2022
noether_tpp/include/noether_tpp/tool_path_planners/raster/raster_planner.h
Show resolved
Hide resolved
tool_path_planner/include/tool_path_planner/plane_slicer_raster_generator.h
Show resolved
Hide resolved
tool_path_planner/include/tool_path_planner/plane_slicer_raster_generator.h
Show resolved
Hide resolved
DavidSpielman
pushed a commit
to DavidSpielman/noether
that referenced
this pull request
Sep 8, 2023
* Raster Planner: Port of Plane Slicer * Update plane slice planner port * Handle empty toolpaths * Ran clang-format * Replace tool_path_planner version of plane slice raster planner with noether_tpp version * Added CI directory symlink * Export dependencies of noether_tpp * Add Eigen3::Eigen target for Xenial compatibility * Remove unneeded clone function * Removed unused headers Co-authored-by: David Merz, Jr <[email protected]> Co-authored-by: Tyler Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tool_path_plannertonoether_tpp.tool_path_planner::PlaneSliceRasterGeneratorwith thenoether_tppversiontool_path_planner::PlaneSliceRasterGenerator