Raster w.r.t. a specified direction #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marip8
changed the title
marip8
force-pushed
the
fix/raster_wrt_global_axes
branch
from
4df2b87 to
8302955
Compare
Levi-Armstrong
approved these changes
Dec 11, 2020
This was referenced Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current surface walk tool path planner does not properly implement the specification of raster direction with respect to an axis defined in the coordinate system of the mesh. This PR eliminates the
raster_wrt_global_axes_flagin favor of utilizing thecut_directionparameter. If any element ofcut_directionis non-zero, it will be used as the raster direction.Under the hood, the
cut_directionvector is projected onto the plane defined by the average normal of the mesh. The projected vector then becomes the raster axis, and the average normal becomes the axis about which the raster axis can be rotated by the specified rotation offset.Examples
Cut Direction = [-1, 1, 0]
Cut direction = [1, 1, 0]
Addresses #110
Merge after #119