Change building of nurbs component due to weird cmake issue #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we know why our CI was passing? I haven't built noether on melodic in a while. |
Now I remember we were getting the same issue but we disabled on everything except noetic. It was melodic which was having the issue. It can be seen in the travis file we pass `-DNURBS_FOUND for melodic which disabled it for that build. I am going to close this issue, because it most likely is only an issue on 18.04. |
|
Fine by me. If this ever gets reopened/merged, I'd request that the new flag be added to the readme. |
|
It may be worth trying a newer version of cmake and see if the issue goes away on melodic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.