[rosserial_python] Stop old thread before recreating new SerialClient #595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
serial_node.py
, when an"Unexpected Error"
occurs, theclient
variable is recreated.However, the
write_thread
thread used in theclient
variable is not released at that time.This will increase the number of threads as "Unexpected Error" is repeated.
I checked the number of thread in
serial_node.py
with the following command.If the number of threads exceeds the
ulimit -u
limit, no other processes can be launched.For your reference, I share the error logs I am getting with my robot.
https://gist.github.com/708yamaguchi/ff32e5921570e7e004836a758665acde