-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wget
for downloading
#86
Conversation
Until we get told to stop, I don't think we should do this. I wouldn't be able to use the package in my normal dev environment for one, and I'm guessing that also goes for the majority of our users. Is there any indication that this rule is anything more than an artifact from old instructions? |
@jonthegeek I can see if I can get some clarity via email with them if you like. Then if the decision is to keep as is, we can just update the README. |
I'm not sure I even read their rules as saying you HAVE to use wget. It's giving it as an example of how to access the files, it seems to me. |
Aha, I wonder if my reading is affected by the reference in the README
and usage of |
Aha! Yeah, I think we should instead make our reference a bit less specific. |
Looking at Terms of Service and a mirror's robots.txt, I think you're right. I will edit this PR! |
Fixed up now. I removed the specific references to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked out! Thanks for giving me a distraction that I could work through on my phone! (see https://bsky.app/profile/jonthegeek.com/post/3lau5bcqdss2t for why that's helpful today!)
Closes #85.
There are many ways this particular issue can be solved, here's one option.
Unfortunately this is currently a breaking change as many users may have been using this without having
wget
installed. Let me know if you think we should perhaps add some logic to allow continued use of non-wget
methods.