Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wget for downloading #86

Merged
merged 9 commits into from
Nov 13, 2024
Merged

Use wget for downloading #86

merged 9 commits into from
Nov 13, 2024

Conversation

jrdnbradford
Copy link
Contributor

Closes #85.

There are many ways this particular issue can be solved, here's one option.

Unfortunately this is currently a breaking change as many users may have been using this without having wget installed. Let me know if you think we should perhaps add some logic to allow continued use of non-wget methods.

@jonthegeek
Copy link
Collaborator

Until we get told to stop, I don't think we should do this. I wouldn't be able to use the package in my normal dev environment for one, and I'm guessing that also goes for the majority of our users. Is there any indication that this rule is anything more than an artifact from old instructions?

@jrdnbradford
Copy link
Contributor Author

@jonthegeek I can see if I can get some clarity via email with them if you like. Then if the decision is to keep as is, we can just update the README.

@jonthegeek
Copy link
Collaborator

I'm not sure I even read their rules as saying you HAVE to use wget. It's giving it as an example of how to access the files, it seems to me.

@jrdnbradford
Copy link
Contributor Author

Aha, I wonder if my reading is affected by the reference in the README

Project Gutenberg allows wget to harvest Project Gutenberg using this list of links. The gutenbergr package visits that page once to find the recommended mirror for the user’s location.

and usage of wget_url in the code. Might just be artifacts of a time long past.

@jonthegeek
Copy link
Collaborator

Aha! Yeah, I think we should instead make our reference a bit less specific.

@jrdnbradford
Copy link
Contributor Author

Looking at Terms of Service and a mirror's robots.txt, I think you're right.

I will edit this PR!

@jrdnbradford
Copy link
Contributor Author

Fixed up now. I removed the specific references to wget in code and docs. Apologies for getting antsy on this! Should have waited for discussion in #85. 🤓

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked out! Thanks for giving me a distraction that I could work through on my phone! (see https://bsky.app/profile/jonthegeek.com/post/3lau5bcqdss2t for why that's helpful today!)

@jonthegeek jonthegeek merged commit 57b1415 into ropensci:main Nov 13, 2024
8 checks passed
@jrdnbradford jrdnbradford deleted the wget branch November 18, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of wget for PG Robot Access Compliance
2 participants