Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File per export #81

Merged
merged 2 commits into from
Oct 14, 2024
Merged

File per export #81

merged 2 commits into from
Oct 14, 2024

Conversation

jrdnbradford
Copy link
Contributor

@jrdnbradford jrdnbradford commented Oct 10, 2024

Closes #67. Between this and work done in #68, I think this gets the export/test structure we want, or at least much closer given the general fuzziness of such decisions.

  • documented gutenberg_add_metadata
  • created a test-data.R file and moved data-related tests there
  • renamed test-metadata.R to test-gutenberg_works.R

Now each exported group of functions has a corresponding test file.

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again! Hopefully I can finish what I'm working on and we can sort all of this out into a release! I might end up doing that this week anyway if it doesn't look like gutenbergr.data is going to wrap up soon.

@jonthegeek jonthegeek merged commit c946d59 into ropensci:main Oct 14, 2024
10 checks passed
@jrdnbradford jrdnbradford deleted the file-per-export branch October 14, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure: File-per-export
2 participants