Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate testthat 3e #80

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Activate testthat 3e #80

merged 2 commits into from
Sep 25, 2024

Conversation

jrdnbradford
Copy link
Contributor

Closes #79.

  • expect_is is deprecated in 3e, switched out for expect_s3_class
  • added show_col_types = FALSE to gutenberg_get_all_mirrors, don't see much reason to show that output and it was showing up in the test output. I can always add a param to control this if you prefer

jonthegeek
jonthegeek approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I didn't think to check this when I took over!

@jonthegeek jonthegeek merged commit cd9ad51 into ropensci:main Sep 25, 2024
10 checks passed
@jrdnbradford
Copy link
Contributor Author

Some GHA checks failed on merge to main, looks like an intermittent issue. I've encountered it several times today. Re-running generally resolves.

@jonthegeek
Copy link
Collaborator

Yeah, I'm rerunning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonthegeek jonthegeek jonthegeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activate testthat 3e?
2 participants
@jrdnbradford @jonthegeek