Skip to content

Commit

Permalink
Better regex
Browse files Browse the repository at this point in the history
  • Loading branch information
jeroen committed Jan 28, 2025
1 parent bfd39df commit e1b26f2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/testthat/test-formats.R
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ test_that("Critical encoders", {
expect_contains(encoders$name, 'libmp3lame')
expect_contains(encoders$name, 'libvorbis')
expect_contains(encoders$name, 'libxvid')
if(!grepl('redhat', R.version$platform)){
if(!grepl("(Fedora|Red Hat)", osVersion)){
# libx264 is not supported on RHEL/Fedora libavfilter-free-devel but it is
# in ffmpeg-devel from rpmfusion.
expect_contains(encoders$name, 'libx264')
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-video.R
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ test_that("convert images into video formats", {
test_that("audio sampling works", {
for(ext in c("mkv", "mp4", "mov", "flv")){
filename <- paste0("test.", ext)
if(grepl('redhat', R.version$platform)){
if(grepl("(Fedora|Red Hat)", osVersion)){
# libavfilter-free-devel only supports certain bitrates?
wonderland <- av_audio_convert(wonderland, tempfile(fileext = '.mka'), sample_rate = 48000, verbose = FALSE)
}
Expand Down

0 comments on commit e1b26f2

Please sign in to comment.