Update to Python 3.6 and different encodings #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedcom takes an iterator of lines instead of a file directly. This allows to apply encoding. Date is a file that delivers a splitDate function to handle the special cases encountered when splitting dates. Added Query class to split concerns between storage and query.
bean5
suggested changes
May 6, 2024
| marriage=1857,marriage_start=1850,marriage_end=1860, | ||
| family_surname='Nicotra',family_given='Maria', | ||
| criteria='surname=N:birthrange=1820-1840:deathrange=1900-1910'): | ||
| birth=1968,birth_start=1940,birth_end=1960, |
There was a problem hiding this comment.
@MatthiasJobst These changes seem to be opinionated and outside the scope of upgrading to a newer version of Python. A quick, cursory review of the other changes did not stand out as out of scope to me.
CC: @zappala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in an effort to use the python library I updated the code to Python 3.6. Further I made some modifications to handle different date and file formats or encodings.
Your work has been a great help and I hope those changes help more people.
Regards,
Matthias