[clad] Bump to master, checking if we can release. #16982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guitargeek, could you do some performance benchmarks to see if we have not regressed? |
Test Results 18 files 18 suites 4d 1h 25m 31s ⏱️ For more details on these failures, see this check. Results for commit 42651e3. |
|
I have checked, and there are no changes in jitting time and runtime for ATLAS and CMS Higgs combination fits. |
|
@guitargeek can this PR then be approved? |
|
Well, not as it is. We can't use Clad |
|
Also there is a regression on windows that I am bisecting. |
|
Thanks, good that this is being followed up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.