[cmake] replace custom FindLibuuid.cmake with upstream version #16971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 files 2 suites 5h 18m 41s ⏱️ Results for commit 2a45f79. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from https://github.com/Kitware/CMake/blob/master/Source/Modules/FindLibUUID.cmake
Alternative for #16957. Needs to be validated on Windows and Mac, but it seems to work fine on Linux where the current FindLibuuid.cmake doesn't.
I'm not sure why this file is not included with cmake by default despite being in their repo for 7+ years; I only found this comment about it. Still, it should work better than our custom script.