Enable CppInterOp #16814
Draft
Enable CppInterOp #16814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CppInterOp](https://github.com/compiler-research/CppInterOp) exposes API from Clang and LLVM in a mostly backward compatibe way. The API support downstream tools that utilize interactive C++ by using the compiler as a service. Adopting more of CppInterOp in ROOT will help simplify the LLVM migration process and allow us to upstream more patches to either CppInterOp or LLVM.
This uses provides InterOp with the TInterpreter instance created by ROOT in TCling. The InterOp API can now be used without providing interpreter ownership.
aaronj0
force-pushed
the
enable-interop
branch
from
9392e07
to
2d038e7
Compare
Test Results 5 files 5 suites 19h 57m 10s ⏱️ For more details on these failures, see this check. Results for commit 2d038e7. |
hahnjo
requested changes
Nov 5, 2024
core/metacling/src/CMakeLists.txt
Outdated
Comment on lines
78
to
79
| add_dependencies(MetaCling CLING clangCppInterOp) | ||
| # target_include_directories(MetaCling SYSTEM PUBLIC ${source_dir}/include/) |
There was a problem hiding this comment.
Can you move these modifications to the next commit, where CppInterOp is used?
Comment on lines
+609
to
+611
| set(LLVM_DIR "${CMAKE_BINARY_DIR}/interpreter/llvm-project/llvm/lib/cmake/llvm") | ||
| set(Clang_DIR "${CMAKE_BINARY_DIR}/interpreter/llvm-project/llvm/tools/clang/lib/cmake/clang") | ||
| set(Cling_DIR "${CMAKE_BINARY_DIR}/interpreter/cling") |
There was a problem hiding this comment.
This will need adapting for externally built LLVM, Clang, and / or Cling. For LLVM and Clang, I believe this should already be taken care of above, no?
| @@ -0,0 +1,372 @@ | |||
| <div align="center"> | |||
|
|
|||
| # CppInterOp | |||
There was a problem hiding this comment.
As discussed offline, we probably want a similar workflow as .github/workflows/llvm-diff.yml to make sure our copies are not diverging
Comment on lines
+70
to
+71
| #include "clang/Interpreter/CppInterOp.h" | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CppInterOp exposes API from Clang and LLVM in a mostly backward compatibe way. The API support downstream tools that utilize interactive C++ by using the compiler as a service.
This PR is the first step in using pure clang based reflection API in meta, and part of eventually integrating the JITCall and DynamicLibraryManager infrastructure.
Adopting more of CppInterOp in ROOT will help simplify the LLVM migration process and allow us to upstream more patches to either CppInterOp or LLVM.