Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RT120946 #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed RT120946 #1

wants to merge 3 commits into from

Conversation

nigelhorne
Copy link

The main fix is the removal of 'my' for a variable already defined in the same scope. The other fixes are around the Makefile.PL which didn't work.

@ronsavage
Copy link
Owner

I've uncovered a can of worms. My source version is 1.03. CPAN is 1.08. The source code for Timeline.pm says 2.07. I think it's best to delete my version of work from CPAN's.

@nigelhorne
Copy link
Author

FWIW, I'm also playing with visjs to decide which I prefer. There are pros and cons of both it an simile.

@ronsavage
Copy link
Owner

ronsavage commented Apr 10, 2017 via email

Copy link
Owner

@ronsavage ronsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx Nigel. Merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants