Example of single package containing both ros1 and ros2 code #1
Conversation
| <maintainer email="[email protected]">rre</maintainer> | ||
| <license>BSD</license> | ||
|
|
||
| <buildtool_depend condition="$ROS_VERSION == 1">catkin</buildtool_depend> |
There was a problem hiding this comment.
is this 'condition' attribute currently supported?
There was a problem hiding this comment.
Yes. It's part of REP-149: Package Manifest Format Three Specification.
| find_package(catkin QUIET) | ||
| find_package(ament_cmake QUIET) |
There was a problem hiding this comment.
Please note that both could be found in situations where both ROS 1 and ROS 2 have been sourced (fi when the ros1bridge is being used).
There was a problem hiding this comment.
Is this something you would do when building or only when running things?
There was a problem hiding this comment.
I am assuming this should not be done when building so I could added a check if both are found it would error.
There was a problem hiding this comment.
Is this something you would do when building or only when running things?
Both. For custom messages or services the bridge needs to be rebuilt. That would be something users will want to do I believe in many cases.
I am assuming this should not be done when building so I could added a check if both are found it would error.
If with "this" you are referring to "sourceing both" then it would be done both at runtime and at build time.
There was a problem hiding this comment.
If this is the case then will there be package name conflicts between ros1 and ros2 packages with the same name?
I came across your example and was interested in seeing if it was possible to contain both ros1 and ros2 into a single package so the package name could be the same in both ros1 and ros2. This PR is not intended to be merged into the master but if you want I can rename this to different package name and keep the original examples to show both ways if you are interested.