fix(assets): use base64 when inlining SVG with foreignObject tag (vit…

…ejs#14875)
rolldown · Nov 5, 2023 · 9e20ed6 · 9e20ed6
1 parent 12f9230
commit 9e20ed6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/vite/src/node/plugins/asset.ts b/packages/vite/src/node/plugins/asset.ts
@@ -437,15 +437,19 @@ export async function urlToBuiltUrl(
 // Inspired by https://github.com/iconify/iconify/blob/main/packages/utils/src/svg/url.ts
 function svgToDataURL(content: Buffer): string {
   const stringContent = content.toString()
-  // If the SVG contains some text, any transformation is unsafe, and given that double quotes would then
+  // If the SVG contains some text or HTML, any transformation is unsafe, and given that double quotes would then
   // need to be escaped, the gain to use a data URI would be ridiculous if not negative
-  if (stringContent.includes('<text')) {
+  if (
+    stringContent.includes('<text') ||
+    stringContent.includes('<foreignObject')
+  ) {
     return `data:image/svg+xml;base64,${content.toString('base64')}`
   } else {
     return (
       'data:image/svg+xml,' +
       stringContent
         .trim()
+        .replaceAll(/>\s+</g, '><')
         .replaceAll('"', "'")
         .replaceAll('%', '%25')
         .replaceAll('#', '%23')