Skip to content

Commit

Permalink
Merge pull request #645 from rollbar/maint/updated-php-versions-in-ci
Browse files Browse the repository at this point in the history
Added PHP 8.4 to CI tests and removed PHP 8.0
  • Loading branch information
danielmorell authored Jan 12, 2025
2 parents 81638a1 + 8c2f7bc commit c5b8e35
Showing 1 changed file with 18 additions and 4 deletions.
22 changes: 18 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ jobs:
matrix:
# All the versions, OS, and dependency levels we want to support
os: [ubuntu] # TODO: windows, macos
php: [ '8.0', '8.1', '8.2', '8.3' ]
php: [ '8.1', '8.2', '8.3', '8.4' ]
dependency: [ stable ]
# Our code has paths for with- and without- XDebug, and we want to test
# both of them.
# @see https://xdebug.org/docs/all_settings#mode
xdebug3-mode: ['develop,coverage', 'coverage']
include:
- php: '8.0'
- php: '8.1'
os: 'ubuntu'
dependency: 'lowest'
xdebug3-mode: 'develop,coverage'
Expand Down Expand Up @@ -73,8 +73,22 @@ jobs:
key: ${{ matrix.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ matrix.dependency }}-
restore-keys: ${{ matrix.os }}-composer-${{ matrix.dependency }}-

- name: Install dependencies
- name: Install dependencies PHP < 8.4
if: matrix.php != '8.4'
run: composer update --prefer-${{ matrix.dependency }} --prefer-dist --no-interaction

- name: Execute tests
- name: Execute tests PHP < 8.4
if: matrix.php != '8.4'
run: composer test

# This is a temporary workaround until vimeo/psalm is updated to support PHP 8.4.
# See https://github.com/vimeo/psalm/issues/11107
- name: Install dependencies PHP 8.4
if: matrix.php == '8.4'
run: composer update --prefer-${{ matrix.dependency }} --prefer-dist --no-interaction --ignore-platform-reqs

- name: Execute tests PHP 8.4
if: matrix.php == '8.4'
run: |
./vendor/bin/phpcs --standard=PSR2 ./src ./tests
./vendor/bin/phpunit --coverage-clover build/logs/clover.xml

0 comments on commit c5b8e35

Please sign in to comment.