Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there @rokoroku 👋 !
Cheers for the amazing repo! It's bloody amazing and quite useful to get something started with React!
This PR is meant to update every dependency, including migration to React 16 and Webpack from v4 to v5. The latter implies changing the
webpack.config.js
file. I've followed the migration guide from Webpack and their recommended practices and put them here! 😄Most importantly:
'[hash]'
to'[content]'
, as recommended from the aforementioned guide. This also deals with caching, so we don't need to worry about different environments.url-loader
,raw-loader
andfile-loader
- also recommended in the guide.loader.options
->loader.postcssOptions
splitChunks.name
fromfalse
totrue
as recommended here.node.fs
workaround, since it's sorted in Webpack 5.devtool
in development mode fromcheap-module-eval-source-map
toeval-cheap-module-source-map
, since it was a breaking change in the latest version of Devtool.disable
property from MiniCssExtractPlugin was removed. So we are conditionally adding it to the plugins array depending on build type (production or development) to mimick the same logic you previously had.Hopefully you can merge this PR so everyone can benefit from an updated version of this amazing repo! 😃