This repository has been archived by the owner on Jul 22, 2023. It is now read-only.
Add attributes support #32
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kampfkarren
commented
Mar 8, 2021
| @@ -102,6 +102,22 @@ pub fn lua_to_rbxvalue(ty: VariantType, value: LuaValue<'_>) -> LuaResult<Varian | |||
| } | |||
| } | |||
|
|
|||
| pub fn guess_type_from_rbxvalue(value: &LuaValue<'_>) -> Option<VariantType> { | |||
There was a problem hiding this comment.
I'm not ecstatic about this. I think it might be better to just make something like setRawAttribute in its place.
There was a problem hiding this comment.
Small note, but RbxValue is a very dead name now, we just call those variants now!
LPGhatguy
reviewed
Mar 8, 2021
| rlua::Error::external("Cannot call GetAttribute() on a destroyed instance") | ||
| })?; | ||
|
|
||
| let attribute_binary_string = match instance.properties.get("AttributesSerialize") { |
There was a problem hiding this comment.
As a heads-up, we'll probably be tweaking the reflection database before attributes go live so that this property becomes just Attributes when in memory.
There was a problem hiding this comment.
Attributes have been live for a few weeks now 😛
There was a problem hiding this comment.
*before attributes go live in rbx-dom :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as draft while waiting for the merging of rojo-rbx/rbx-dom#166. Currently this just uses my repository. PR made anyway for code review.