Re-export AHashMap and give it a trait extension #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expose
AHashMapviaWeakDom::into_rawso we should probably re-export it same asUstrMap. If we do that it makes sense to also implement the helper trait for it.Also, we should use the actual
AHashMaptype rather than the HashMap alias because it impacts how it's surfaced in the type signature. Better to show explicitly that we're usingAHashMapfor this than have it silently disappear because the type isHashMap.This came up while I was porting Rojo to use the new changes for Uplift, so I may end up with more pull requests if other UX issues come up.