Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RobloxString to rbx_types, use it for instance names #478

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

kennethloeffler
Copy link
Member

@kennethloeffler kennethloeffler commented Nov 11, 2024

This PR partially addresses #475 by adding a new RobloxString enum to rbx_types and using it for InstanceBuilder.name and Instance.name.

This PR changes nearly every test snapshot we have, so the diff is crazy, I'm sorry.

There's still some stuff left to do here:

  • Add documentation to RobloxString
  • Add Deserialize implementation to RobloxString
  • Review RobloxString's API - maybe there should be a to_utf8_lossy method or something like it?
  • Maybe there should be warnings when we need to lossily serialize a RobloxString::Binary?

@kennethloeffler
Copy link
Member Author

kennethloeffler commented Nov 11, 2024

I'm not really sure if we want to merge this in for the next batch of releases. It is a breaking change to rbx_dom_weak, and we've already made some breaking changes so there is some merit to including it, but there's still a decent amount of work and review left on it and it's probably not worth blocking the big performance improvements we have in the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant