Add RobloxString to rbx_types, use it for instance names #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #475 by adding a new
RobloxString
enum to rbx_types and using it forInstanceBuilder.name
andInstance.name
.This PR changes nearly every test snapshot we have, so the diff is crazy, I'm sorry.
There's still some stuff left to do here:
to_utf8_lossy
method or something like it?