Add rbx_binary Miner's Haven benchmark and readme #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Criterion.rs documentation states that "SmallInput indicates that the input to the benchmark routine [...] is small enough that millions of values can be safely held in memory." 1KB seems like a good cutoff to use to start using LargeInput, if we take "millions of values" to mean ~3,000,000.
kennethloeffler
force-pushed
the
miners-haven-benchmark-readme
branch
from
f67f4ca to
038fe75
Compare
Dekkonot
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a benchmark for Miner's Haven, a real-world Roblox game that is open sourced at https://github.com/berezaa/minershaven. It's representative of workloads rbx_binary will see most often.
It also adds a readme that documents how the benchmark suite works and how to use it.