Use UstrSet for TypeInfo.properties_visited and TypeInfo.aliases #469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better rbx_binary serialization performance, this PR changes the type of
TypeInfo.properties_visited
fromHashSet<(Ustr, VariantType)>
toUstrSet
, and changes the type ofTypeInfo.aliases
fromBTreeSet<Ustr>
toUstrSet
. These changes are sound because:TypeInfo.properties_visited
entries is not used for anything outside of the collection, and it's impossible for an instance to contain multiple properties that have the same name, but different types.TypeInfo.aliases
is unimportant.On my machine, serialization benchmark results compared to latest master are as follows: