Use ahash for most HashMaps and HashSets #466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces most
HashMap
s withAHashMap
. I did it the lazy way with type aliases, didn't do anything to rbx_xml (yet?), and haven't touched the changelogs yet, because I am tired and I want to go to bed! It's kind of invasive, and might make the library harder to use, but we do get a nice performance boost from it.On my machine, this improves rbx_binary's "Deserialize 10,000 Parts" and "Serialize 10,000 Parts" benchmarks by ~15% and ~19%, respectively.