Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer className alias patch to Object class, update db #456

Merged

Conversation

kennethloeffler
Copy link
Member

Today, Roblox changed the base class of Instance to a new abstract base class called Object. As part of this change, the ClassName and className properties now belong to Object, which currently causes rbx_reflector generate to exit with an error due to an alias patch for className:

     Running `target/debug/rbx_reflector generate rbx_reflection_database/database.msgpack rbx_dom_lua/src/database.json --patches patches`
[INFO  rbx_reflector::cli::defaults_place] Installing Studio plugin
[INFO  rbx_reflector::cli::defaults_place] Starting Roblox Studio...
[INFO  rbx_reflector::cli::defaults_place] Waiting for Roblox Studio to re-save place...
[INFO  rbx_reflector::cli::defaults_place] Uninstalling Studio plugin
[INFO  rbx_reflector::cli::defaults_place] Place saved, killing Studio...
Error: Property Instance.className modified in patch file does not exist in database

This PR changes the className alias patch so it's appropriately on the Object class, and updates the reflection database.

(does this change need a more specific changelog entry beyond "updated to Roblox 647")?

@kennethloeffler
Copy link
Member Author

Brittle test :(

hold on....

@kennethloeffler kennethloeffler merged commit bf60df5 into rojo-rbx:master Oct 22, 2024
3 checks passed
@kennethloeffler kennethloeffler deleted the move-classname-to-object-class branch October 22, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants