Override the default value of WorldPivotData
to be null
#450
+834
−488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model.WorldPivotData
isn't serialized as a real value by Roblox unless it's explicitly set. We should probably mimic this behavior.The reason it hasn't been this value is because of pivot migrations. If a Model is inserted without
NeedsPivotMigration
set tofalse
(as is the case in rbx-reflector), Roblox generates a pivot and serializes it, rather than leaving it blank.If you instead insert a model that has
NeedsPivotMigration
set tofalse
but doesn't have any other properties set, you can see thatWorldPivotData
is left blank.