Wait for game.Name to change before running rbx-reflector plugin #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
approved these changes
Sep 23, 2024
kennethloeffler
deleted the
rbx-reflector-wait-for-game-name-changed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the rbx-reflector Roblox Studio plugin so that it waits for
game.Nameto change before checking that the place it's running in is the defaults place.This is necessary because (likely) after https://devforum.roblox.com/t/place-open-improvements-test/3086811,
game.Nameis only set to the value specified in the place file sometime after opening the place, meaning that the rbx-reflector plugin in its current state will never run.Since it doesn't seem prudent to assume that
game.Namewill always have this behavior, there is a two second timeout.