Add method for getting the superclasses of an Instance to rbx_reflection #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It uses a HashSet for convenience. It's slightly more expensive than a Vec but provides an easy mechanism for checking if a class is in the returned set, so it feels worth it.
Not sure if I agree - is Vec::contains any harder to use than HashSet::contains? And what's the maximum possible number of superclasses returned by this method?
|
I hadn't actually checked what the maximum amount was since it felt like it's either 1 or like 5 for most classes. It turns out it is 6. With that in mind, I think a Vec is fine and I'm also going to update the starting capacity to just be 6. |
kennethloeffler
requested changes
Mar 14, 2024
kennethloeffler
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fairly common to need a list of superclasses for a class, so we should provide a method for it. This is an implementation.
It uses a
HashSetfor convenience. It's slightly more expensive than aVecbut provides an easy mechanism for checking if a class is in the returned set, so it feels worth it.