Add name validation to rbx_dom_lua Attributes writer #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instance:SetAttribute
errors when passed invalid attribute names. The name must:This PR adds validation to rbx_dom_lua's
Attributes
custom writer to guard against these, and if any fail, returnsfalse
(but will still attempt to set all the attributes). In the future, once Rojo's patch visualizer has more rich display ofAttributes
values, we could return a more detailed error with specific information about which ones failed.The alternative is throwing the
SetAttribute
into a protected call, but eh..