Remove erroring SecurityCapabilities lua coder/decoder #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
It does feel as though this is fixing a symptom rather than the underlying problem, since we should really not be sending properties we know aren't scriptable through Rojo to begin with and this wouldn't be a problem if we didn't. That said, this is also an issue so I'm okay with it.
In the future it may be worth looking into whether we can have a better mechanism for distinguishing between "unimplemented" and "unknown" for rbx_dom_lua, but that day is not today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this coder/decoder was introduced in imitation of some other types, but the other types that have erroring implementations either:
Region3)Ref)SharedString, although I think there is a case to be made thatSharedStringshould NOT have an erroring lua coder/decoder)SecurityCapabilitiesexists on all instances so an erroring implementation is inappropriate and causes problems for Rojo as per rojo-rbx/rojo#802. I think we can just remove the lua encoder/decoder, like howUniqueIdsimply doesn't have them either.