Skip to content

Commit

Permalink
Break rbx_reflector file watcher receive loop after modify events (#384)
Browse files Browse the repository at this point in the history
On macOS, the file watcher emits a modify event after saving the
defaults place in Roblox Studio, making it impossible to successfully
use rbx_reflector. This PR fixes this by changing the event receive loop
in rbx_reflector's defaults place command so that it also checks for
modify events.
  • Loading branch information
kennethloeffler authored Jan 26, 2024
1 parent bdaeb8d commit b521e0e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rbx_reflector/src/cli/defaults_place.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ fn save_place_in_studio(path: &PathBuf) -> anyhow::Result<StudioInfo> {
println!("Please save the opened place in Roblox Studio (ctrl+s).");

loop {
if rx.recv()??.kind.is_create() {
let event = rx.recv()??;
if event.kind.is_create() || event.kind.is_modify() {
break;
}
}
Expand Down

0 comments on commit b521e0e

Please sign in to comment.