Patch Instance.DefinesCapabilities to alias to Instance.Sandboxed (…

…#459)
rojo-rbx · Oct 30, 2024 · 33b600f · 33b600f
1 parent 70e70fd
commit 33b600f
Show file tree

Hide file tree

Showing 12 changed files with 1,337 additions and 1,307 deletions.
diff --git a/patches/instance.yml b/patches/instance.yml
@@ -21,6 +21,15 @@ Change:
       DefaultValue:
         Bool: true
 
+    # DefinesCapabilities is exposed as `Sandboxed` in Roblox Studio, so we want
+    # it as an alias.
+    DefinesCapabilities:
+      AliasFor: Sandboxed
+    Sandboxed:
+      Serialization:
+        Type: SerializesAs
+        As: DefinesCapabilities
+
     # Attributes serialize as a BinaryString with a strange name, but we want to
     # refer to them with a different name.
     Attributes:
@@ -36,4 +45,4 @@ Change:
     Tags:
       DataType:
         Value: "Tags"
-      Scriptability: Custom
+      Scriptability: Custom
diff --git a/.../src/tests/snapshots/rbx_binary__tests__util__lighting-with-int32-attribute__decoded.snap b/.../src/tests/snapshots/rbx_binary__tests__util__lighting-with-int32-attribute__decoded.snap
@@ -29,8 +29,6 @@ expression: decoded_viewed
         - 0
         - 0
         - 0
-    DefinesCapabilities:
-      Bool: false
     EnvironmentDiffuseScale:
       Float32: 1
     EnvironmentSpecularScale:
@@ -57,6 +55,8 @@ expression: decoded_viewed
         - 0.27450982
     Outlines:
       Bool: false
+    Sandboxed:
+      Bool: false
     ShadowSoftness:
       Float32: 0.2
     SourceAssetId:
@@ -68,3 +68,4 @@ expression: decoded_viewed
     TimeOfDay:
       String: "14:30:00"
   children: []
+
diff --git a/.../src/tests/snapshots/rbx_binary__tests__util__lighting-with-int32-attribute__encoded.snap b/.../src/tests/snapshots/rbx_binary__tests__util__lighting-with-int32-attribute__encoded.snap
@@ -54,12 +54,6 @@ chunks:
         - - 0
           - 0
           - 0
-  - Prop:
-      type_id: 0
-      prop_name: DefinesCapabilities
-      prop_type: Bool
-      values:
-        - false
   - Prop:
       type_id: 0
       prop_name: EnvironmentDiffuseScale
@@ -130,6 +124,12 @@ chunks:
       prop_type: Bool
       values:
         - false
+  - Prop:
+      type_id: 0
+      prop_name: DefinesCapabilities
+      prop_type: Bool
+      values:
+        - false
   - Prop:
       type_id: 0
       prop_name: ShadowSoftness
@@ -166,3 +166,4 @@ chunks:
         - - 0
           - -1
   - End
+
diff --git a/...snapshots/rbx_binary__tests__util__number-values-with-security-capabilities__decoded.snap b/...snapshots/rbx_binary__tests__util__number-values-with-security-capabilities__decoded.snap
@@ -10,7 +10,7 @@ expression: decoded_viewed
       Attributes: {}
     Capabilities:
       SecurityCapabilities: 0
-    DefinesCapabilities:
+    Sandboxed:
       Bool: false
     SourceAssetId:
       Int64: -1
@@ -27,7 +27,7 @@ expression: decoded_viewed
       Attributes: {}
     Capabilities:
       SecurityCapabilities: 2882400000
-    DefinesCapabilities:
+    Sandboxed:
       Bool: false
     SourceAssetId:
       Int64: -1

diff --git a/...snapshots/rbx_binary__tests__util__number-values-with-security-capabilities__encoded.snap b/...snapshots/rbx_binary__tests__util__number-values-with-security-capabilities__encoded.snap
@@ -26,20 +26,20 @@ chunks:
       values:
         - 0
         - 2882400000
-  - Prop:
-      type_id: 0
-      prop_name: DefinesCapabilities
-      prop_type: Bool
-      values:
-        - false
-        - false
   - Prop:
       type_id: 0
       prop_name: Name
       prop_type: String
       values:
         - Hmmm
         - WhereIs
+  - Prop:
+      type_id: 0
+      prop_name: DefinesCapabilities
+      prop_type: Bool
+      values:
+        - false
+        - false
   - Prop:
       type_id: 0
       prop_name: SourceAssetId