Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten outputs for chained boolean operations where possible #325

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Flatten outputs for chained boolean operations where possible #325

wants to merge 1 commit into from

Commits on Mar 8, 2022

  1. Flatten outputs for chained boolean operations where possible 

    Add special-case handling to flatten the data structure when chaining
multiple AND/OR together; for example, make f_and(f_and(x, y), z)
work approximately in the same way as f_and(x, y, z).

The goal here is to avoid a stack overflow when using a pattern which
can chain a large number of futures. Previously, an overflow could start
to happen if the chain was a few hundred futures deep, since each
future's completion callback would set the result on the next future
which would invoke another completion callback and so on throughout the
chain.

Fixes #320
    @rohanpm
    rohanpm committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    d8a8bc0 View commit details
    Browse the repository at this point in the history