Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1文字変数を粛正 #173

Merged
merged 5 commits into from
May 10, 2024
Merged

1文字変数を粛正 #173

merged 5 commits into from
May 10, 2024

Conversation

rein0925
Copy link
Contributor

@rein0925 rein0925 commented May 4, 2024

しました

@rein0925 rein0925 requested a review from H1rono May 4, 2024 07:19
@H1rono H1rono requested a review from Chikurin1014 May 4, 2024 07:42
H1rono
H1rono reviewed May 4, 2024
View reviewed changes
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

方針は合ってますが、もうひと捻り加えたいところ

include/schneider_model.hpp Outdated Show resolved Hide resolved
include/schneider_model.hpp Outdated Show resolved Hide resolved
include/schneider_model.hpp Outdated Show resolved Hide resolved
include/schneider_model.hpp Show resolved Hide resolved
include/schneider_model.hpp Show resolved Hide resolved
@H1rono H1rono linked an issue May 4, 2024 that may be closed by this pull request
1文字変数を粛清 #146
Closed
Chikurin1014
Chikurin1014 reviewed May 5, 2024
View reviewed changes
Copy link
Contributor

@Chikurin1014 Chikurin1014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないと思います

@rein0925 rein0925 requested a review from H1rono May 8, 2024 16:41
@H1rono H1rono mentioned this pull request May 9, 2024
Open
H1rono
H1rono reviewed May 9, 2024
View reviewed changes
src/schneider_model.cpp Outdated Show resolved Hide resolved
@rein0925 rein0925 requested a review from H1rono May 10, 2024 14:27
@H1rono H1rono merged commit efe83cf into main May 10, 2024
6 checks passed
@H1rono H1rono deleted the purge-single-letter-variable branch May 10, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chikurin1014 Chikurin1014 Chikurin1014 left review comments

@H1rono H1rono H1rono approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1文字変数を粛清
3 participants
@rein0925 @H1rono @Chikurin1014