Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a section for cuircuit developers #137

Merged
merged 3 commits into from
Apr 18, 2024
Merged

add a section for cuircuit developers #137

merged 3 commits into from
Apr 18, 2024

Conversation

Chikurin1014
Copy link
Contributor

#82

On branch section-for-dev-circuit
Changes to be committed:
	new file:   docs/for-developers/dev-circuit.md
@Chikurin1014 Chikurin1014 requested a review from H1rono April 17, 2024 00:28
@Chikurin1014 Chikurin1014 self-assigned this Apr 17, 2024
@Chikurin1014
Copy link
Contributor Author

Warning表記何もわかってないので教えてください

Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUMMARY.mdの方もよしなに書いて欲しいです

Comment on lines 85 to 86
[!WARNING]
ハウジングのツメ ≠ コンタクトのツメ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この記法ないので、↓に従ってください
https://rust-lang.github.io/mdBook/format/mdbook.html#classwarning

@@ -0,0 +1,111 @@
# 開発者向けセクション 回路
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUMMARYの方で開発者向けというのは示してるから、二重で書く必要はないかな

## はんだ付け

- DCモータ
- 向きがそろっていればなんでもよい。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50行目とインデント幅が違う
4マスのインデントが好みなのでそうしてください

modified the title of the section
use a warning field in proper way
fixed indent size
@Chikurin1014
Copy link
Contributor Author

Chikurin1014 commented Apr 17, 2024

@H1rono 再確認お願いします pushしてなかった したのでお願いします

@Chikurin1014
Copy link
Contributor Author

Chikurin1014 commented Apr 17, 2024

@rein0925
GoogleDriveで共有されている納品表の緑色LEDのリンクが黄色LEDになっていたのと、秋月電子のリンクが一部古いものになっていた(まだリダイレクトが効いているので、開くことはできる)ので、こちらのドキュメントで修正を加えています。(Driveの方は直してません)

| 電池ボックス | 赤 > 黒
| 電池電池スナップ | 赤 > 黒

<div class = Warning>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そんな書き方見たことないけど

@Chikurin1014
Copy link
Contributor Author

お願いします

@H1rono H1rono merged commit 58c72c5 into main Apr 18, 2024
6 checks passed
@H1rono H1rono deleted the section-for-dev-circuit branch April 18, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants