Merge pull request #111 from rogy-AquaLab/clang-titdy-magic-number

0.5F を定数に変更
rogy-AquaLab · Apr 6, 2024 · bf81539 · bf81539
2 parents 193cc71 + 2227d86
commit bf81539
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/include/schneider_model.hpp b/include/schneider_model.hpp
@@ -27,6 +27,11 @@ constexpr float a = 0.1;   // NOLINT: FIXME
  */
 constexpr int trial_num = 1000;
 
+/**
+ * @brief volumeの閾値
+ */
+constexpr float volumeThreshold = 0.5F;
+
 /**
  * @brief モータへの出力を計算するクラス
  */

diff --git a/src/schneider_model.cpp b/src/schneider_model.cpp
@@ -199,7 +199,7 @@ void Schneider::set_q() {
 void Schneider::rotate() {
     fet_1 = 0.5F;
     fet_2 = 0.5F;
-    if (volume_ < 0.5F) {
+    if (volume_ < volumeThreshold) {
         servo_1.pulsewidth_us(550);
         servo_2.pulsewidth_us(2350);
     } else {