Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataclass typevar #51

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Fix dataclass typevar #51

merged 4 commits into from
Jan 19, 2024

Conversation

rogiervandergeer
Copy link
Owner

@rogiervandergeer rogiervandergeer commented Jan 12, 2024 •
edited
Loading

Fix the mypy error

 error: Value of type variable "Dataclass" of "parse" cannot be "Config"  [type-var]

For all instances of our tests (and examples)

@rogiervandergeer rogiervandergeer marked this pull request as ready for review January 12, 2024 15:36
antonsteenvoorden
antonsteenvoorden approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@antonsteenvoorden antonsteenvoorden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rogiervandergeer
Merge branch 'main' into rvdg-fix-typing
cd866ab 
# Conflicts:
#	tests/test_parse.py
@rogiervandergeer
Merge branch 'main' into rvdg-fix-typing
da03e89 
# Conflicts:
#	tests/test_recursive.py
@rogiervandergeer rogiervandergeer merged commit 564457a into main Jan 19, 2024
3 checks passed
@rogiervandergeer rogiervandergeer deleted the rvdg-fix-typing branch January 19, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonsteenvoorden antonsteenvoorden antonsteenvoorden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rogiervandergeer @antonsteenvoorden