Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ApiSpecDoc event listener. #19

Merged
merged 9 commits into from
Aug 27, 2022
Merged

Create ApiSpecDoc event listener. #19

merged 9 commits into from
Aug 27, 2022

Conversation

AlexS778
Copy link
Contributor

@AlexS778 AlexS778 commented Aug 25, 2022 •
edited by ldmi3i
Loading

Description

Working on a event listener - #9

Dependent #9

Current status

  • Waiting for review
  • Waiting for comment resolution
  • Waiting for merge
  • Draft
  • Trivial PR (nominal cosmetic/typo/whitespace changes)

Semantic Versioning

Please delete options that are not relevant. Ensure same has been covered in the commit message as well.

  • This is a feat

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

The reviewer is going to perform some tests.

Checklist:

  • My commit message mentions fix, feat, BREAKING CHANGE accordingly to increase the semantic versioning
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code/docs and corrected any misspellings

@AlexS778 AlexS778 linked an issue Aug 26, 2022 that may be closed by this pull request
Create ApiSpecDoc event listener #9
Closed
ldmi3i
ldmi3i requested changes Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@ldmi3i ldmi3i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Left just several cosmetic comments

internal/config/queue.go Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
internal/app.go Outdated Show resolved Hide resolved
ldmi3i
ldmi3i requested changes Aug 27, 2022
View reviewed changes
Copy link
Collaborator

@ldmi3i ldmi3i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. One more comment on test)

internal/config/application_test.go Outdated Show resolved Hide resolved
@ldmi3i ldmi3i merged commit b0c6c31 into main Aug 27, 2022
@ldmi3i ldmi3i deleted the feature/ApiSpecDoc_event_listener branch August 27, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldmi3i ldmi3i ldmi3i approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create ApiSpecDoc event listener
2 participants
@AlexS778 @ldmi3i