Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments for Linux exotic arches #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dra27
Copy link

@dra27 dra27 commented Jul 26, 2023

ocaml/ocaml#12405 proposes using linux everywhere for the "system" variable. The change doesn't semantically affect the script, but it seemed worth a clarifying comment not to rely on the old system values in future.

@hannesm
Copy link
Collaborator

hannesm commented Jul 31, 2023

Would it make sense to be a bit more specific when you write "Historically" -- i.e. from when till when (since AFAIU the ocaml runtime system will soon change something in that regards?). Thanks a lot for your PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants